Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker: do not look up context twice in PostMessage #38784

Merged
merged 1 commit into from
Jun 2, 2021
Merged

worker: do not look up context twice in PostMessage #38784

merged 1 commit into from
Jun 2, 2021

Conversation

addaleax
Copy link
Member

@addaleax addaleax mentioned this pull request May 23, 2021
Closed
@github-actions github-actions bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 23, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38290/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38300/

@ronag ronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 2, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38451/

@addaleax @aduh95
worker: do not look up context twice in PostMessage
bcf73d6 
Refs: nodejs#38780 (comment)

PR-URL: nodejs#38784
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@aduh95 aduh95 force-pushed the postmessage-no-lookup-context-twice branch from 4f12682 to bcf73d6 Compare June 2, 2021 17:30
@aduh95
Copy link
Contributor

aduh95 commented Jun 2, 2021

Landed in bcf73d6

@aduh95 aduh95 merged commit bcf73d6 into nodejs:master Jun 2, 2021
targos pushed a commit that referenced this pull request Jun 11, 2021
@addaleax @targos
worker: do not look up context twice in PostMessage
f959cb3 
Refs: #38780 (comment)

PR-URL: #38784
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@danielleadams danielleadams mentioned this pull request Jun 14, 2021
Merged
richardlau pushed a commit that referenced this pull request Jul 16, 2021
@addaleax @richardlau
worker: do not look up context twice in PostMessage
c53184e 
Refs: #38780 (comment)

PR-URL: #38784
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
@addaleax @richardlau
worker: do not look up context twice in PostMessage
632aace 
Refs: #38780 (comment)

PR-URL: #38784
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@addaleax @richardlau
worker: do not look up context twice in PostMessage
2c28e00 
Refs: #38780 (comment)

PR-URL: #38784
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@richardlau richardlau mentioned this pull request Jul 20, 2021
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@addaleax @foxxyz
worker: do not look up context twice in PostMessage
7554930 
Refs: nodejs#38780 (comment)

PR-URL: nodejs#38784
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bl-ue bl-ue bl-ue approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@JungMinu JungMinu JungMinu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@addaleax @nodejs-github-bot @aduh95 @jasnell @targos @cjihrig @JungMinu @gireeshpunathil @bl-ue @ronag